Code review comment for lp://qastaging/~mzanetti/unity8/surfacetitles-in-quicklist

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> fixed the last 2. Yes, could typedef the first one but I personally am not a
> fan of typedefs... makes the code more opaque IMO as the reader has to look up
> what the type actually is...

+1

They're not always helpful. Telling from experience from reading Mir and MirAL code.

« Back to merge proposal