Code review comment for lp://qastaging/~nataliabidart/desktopcouch/remove-testtools

On Fri, Jan 7, 2011 at 1:12 AM, Naty Bidart
<email address hidden> wrote:
> Hi Rob,
>
> As you can see in the diff, testtools was only used to provide the TestCase class and nothing more, and from the TestCase class we only used methods that are provided by unittest.TestCase.
>
> So, since unittest is part of Python's standard library will always be available in the Ubuntu main repo, which is very important for us since we ship packages in that repo and usually in the CD, where the space is tight and if we need to add a new dependency we need to follow a very strict process.
>
> When possible, we try to stick to the dependencies we already have and/or already are on the Ubuntu CD, such as unittest and trial. This particular project already depends on unittest, twisted trial and mocker, so for this particular case I find testtools an extra dep that is not providing an irreplaceable functionality, and since is not installed by default, I personally don't see the gain of having it.
>
> Don't get me wrong, I congratulate you two for maintaining testtools, I think you're doing an amazing job. Thanks!

Hi, thanks for that feedback. I don't know if you are aware, but
python-testtools is in main - the bzr devs did a MIR for it a few
weeks ago so that bzr can run its test suite at build time. I don't
understand why you'd need your *build* deps on the CD - could you
expand on that?

One thing you may not know is that latest testtools can run both
regular python code tests and tests that need to do stuff with the
twisted reactor - it completely obsoletes twisted.trial now :)

Cheers,
Rob