Merge lp://qastaging/~nataliabidart/ubuntuone-control-panel/disable-files into lp://qastaging/ubuntuone-control-panel

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 122
Merged at revision: 125
Proposed branch: lp://qastaging/~nataliabidart/ubuntuone-control-panel/disable-files
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 409 lines (+104/-9)
4 files modified
ubuntuone/controlpanel/backend.py (+11/-2)
ubuntuone/controlpanel/gtk/gui.py (+17/-7)
ubuntuone/controlpanel/gtk/tests/test_gui.py (+19/-0)
ubuntuone/controlpanel/tests/test_backend.py (+57/-0)
To merge this branch: bzr merge lp://qastaging/~nataliabidart/ubuntuone-control-panel/disable-files
Reviewer Review Type Date Requested Status
Chad Miller (community) Approve
Roberto Alsina (community) Approve
Review via email: mp+56217@code.qastaging.launchpad.net

Commit message

- Unify disable/enable file sync functionality among Services tab and global file sync status (LP: #729301).
- Cloud Folders tab is now disabled when the file sync service is (LP: #747482).

Description of the change

In order to test, you need to be running ubuntuone-client revno 932 or higher.

Then, using 2 terminals, you should:

1$> DEBUG=True PYTHONPATH=~/path/to/u1/client/revno-932-or-higher/:. ./bin/ubuntuone-control-panel-backend

2$> DEBUG=True PYTHONPATH=~/path/to/u1/client/revno-932-or-higher/:. ./bin/ubuntuone-control-panel-gtk

Go to the services tab and play with the 'enable file sync' checkbox. The global file sync status bar should be updated properly.
Go

To post a comment you must log in.
122. By Natalia Bidart

Cloud Folders tab is now disabled when the file sync service is (LP: #747482).

Revision history for this message
Roberto Alsina (ralsina) wrote :

+1

review: Approve
Revision history for this message
Chad Miller (cmiller) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches