Ubuntu One Control Panel

Merge lp://qastaging/~nataliabidart/ubuntuone-control-panel/folders-if-new-creds into lp://qastaging/ubuntuone-control-panel

  1. folders-if-new-creds
  2. Merge into trunk
Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 36
Merged at revision: 34
Proposed branch: lp://qastaging/~nataliabidart/ubuntuone-control-panel/folders-if-new-creds
Merge into: lp://qastaging/ubuntuone-control-panel
Prerequisite: lp://qastaging/~nataliabidart/ubuntuone-control-panel/subscribe
Diff against target: 215 lines (+84/-14)
2 files modified
ubuntuone/controlpanel/gtk/gui.py (+20/-8)
ubuntuone/controlpanel/gtk/tests/test_gui.py (+64/-6)
To merge this branch: bzr merge lp://qastaging/~nataliabidart/ubuntuone-control-panel/folders-if-new-creds
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Roman Yepishev (community) fieldtest Approve
Review via email: mp+43699@code.qastaging.launchpad.net

Commit message

* After machine was added, Folders page is shown (LP: #674459).* VolumesInfoError signal is now handled (LP: #690292).

* VolumesInfoError signal is now handled (LP: #690292).

* When FileSyncStatusError is received, no more DbusException messages are leaked to the end user (LP: #690305).

Description of the change

To run the tests, use the command:

./run-tests

To test, open 2 terminals pointing to this branch.
You should remove your Ubuntu One token from seahorse to ensure following the expected workflow.

In terminal 1:

DEBUG=True PYTHONPATH=. ./bin/ubuntuone-control-panel-backend

In terminal 2:

DEBUG=True PYTHONPATH=. ./bin/ubuntuone-control-panel-gtk

You'll see the "overview" screen (just like https://bugs.launchpad.net/ubuntuone-control-panel/+bug/690315/+attachment/1766070/+files/u1cp-overview.png).

Login (or register, as you prefer) and you should be taken directly to the "Folders" tab.
If you close the GTK UI and re open, you'll see the Account page.

To post a comment you must log in.
lp://qastaging/~nataliabidart/ubuntuone-control-panel/folders-if-new-creds updated
36. By Natalia Bidart

Binding bug nhumbers.

Revision history for this message
Roman Yepishev (rye) wrote :

Folders tab showing after authorization, account tab showing on subsequent startups: OK
Volume list errors: http://ubuntuone.com/p/U17/: OK
File status retrieval error: http://ubuntuone.com/p/U1G/: OK

review: Approve (fieldtest)
Revision history for this message
Roberto Alsina (ralsina) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches