Merge lp://qastaging/~nataliabidart/ubuntuone-control-panel/handle-credentials-error into lp://qastaging/ubuntuone-control-panel
Proposed by
Natalia Bidart
| Status: | Merged |
|---|---|
| Approved by: | Natalia Bidart |
| Approved revision: | 303 |
| Merged at revision: | 299 |
| Proposed branch: | lp://qastaging/~nataliabidart/ubuntuone-control-panel/handle-credentials-error |
| Merge into: | lp://qastaging/ubuntuone-control-panel |
| Diff against target: |
250 lines (+92/-22) 7 files modified
data/qt/ubuntuone.qss (+9/-0) ubuntuone/controlpanel/gui/qt/__init__.py (+33/-5) ubuntuone/controlpanel/gui/qt/tests/__init__.py (+11/-5) ubuntuone/controlpanel/gui/qt/tests/test_common.py (+3/-2) ubuntuone/controlpanel/gui/qt/tests/test_controlpanel.py (+1/-3) ubuntuone/controlpanel/gui/qt/tests/test_wizard.py (+22/-1) ubuntuone/controlpanel/gui/qt/wizard.py (+13/-6) |
| To merge this branch: | bzr merge lp://qastaging/~nataliabidart/ubuntuone-control-panel/handle-credentials-error |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Diego Sarmentero (community) | Approve | ||
| Roberto Alsina (community) | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1 I suggested connecting box.finished to box.deleteLater to avoid leaking it, but it's +1 with or without that.