Merge lp://qastaging/~nataliabidart/ubuntuone-control-panel/unicode-gettext into lp://qastaging/ubuntuone-control-panel

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 264
Merged at revision: 263
Proposed branch: lp://qastaging/~nataliabidart/ubuntuone-control-panel/unicode-gettext
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 148 lines (+8/-50)
4 files modified
bin/ubuntuone-control-panel-gtk (+0/-5)
bin/ubuntuone-control-panel-qt (+1/-8)
setup.py (+0/-35)
ubuntuone/controlpanel/gui/__init__.py (+7/-2)
To merge this branch: bzr merge lp://qastaging/~nataliabidart/ubuntuone-control-panel/unicode-gettext
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
Roman Yepishev (community) fieldtest Approve
Review via email: mp+94136@code.qastaging.launchpad.net

Commit message

- Make gettext return unicode so we can format strings
  with unicode variables (LP: #937809).

To post a comment you must log in.
Revision history for this message
Roman Yepishev (rye) wrote :

Tested with spanish an russian locales - works properly.

review: Approve (fieldtest)
Revision history for this message
Manuel de la Peña (mandel) wrote :

+1 for this.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches