Code review comment for lp://qastaging/~nskaggs/update-manager/fix-for-702418

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Michael, my idea in only checking for "gnome" was that only gnome 2.x
would need the old gnome dbus check. Unity and gnome shell both
support the the new freedesktop interace, as does kde and xfce and
lxde.

I'll go ahead and drop the old interface call completely and update
the branch. I will also attempt to confirm with the gnome developers
that we are free to drop legacy support. Thanks,

Nicholas

On Mon, Nov 7, 2011 at 4:16 AM, Michael Vogt <email address hidden> wrote:
> Review: Needs Information
>
> Thanks for your branch!
>
> Testing for gnome in the env is not quite sufficient as the default session will use
> "XDG_CURRENT_DESKTOP=Unity" and DESKTOP_SESSION=ubuntu these days. Actually this makes
> me wonder if calling the old interface can be dropped entirely? Could you maybe check
> if gnome now supports the freedesktop one?
> --
> https://code.launchpad.net/~nskaggs/update-manager/fix-for-702418/+merge/81298
> You are the owner of lp:~nskaggs/update-manager/fix-for-702418.
>

« Back to merge proposal