Merge lp://qastaging/~nuclearbob/utah/minus-one-retry into lp://qastaging/utah

Proposed by Max Brustkern
Status: Merged
Merged at revision: 1030
Proposed branch: lp://qastaging/~nuclearbob/utah/minus-one-retry
Merge into: lp://qastaging/utah
Diff against target: 13 lines (+3/-0)
1 file modified
utah/run.py (+3/-0)
To merge this branch: bzr merge lp://qastaging/~nuclearbob/utah/minus-one-retry
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Review via email: mp+200905@code.qastaging.launchpad.net

Description of the change

This change retries is_utah_done when ssh returns a -1 exit status. In my testing, this solved issues where utah would stop running after attempting to contact a machine that would not accept connections because it was in the process of rebooting. If this change is acceptable, I think it may make working with rebooting machines over ssh more reliable, which will be helpful for bootspeed.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Also, the current default client_install_timeout of 60 seconds seems a little tight. I can just adjust that in the job if needed, but I think a higher default could be helpful to other jobs, so I can add this or make a new merge for it if that's desired.

Revision history for this message
Andy Doan (doanac) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches