UTAH

Merge lp://qastaging/~nuclearbob/utah/reset-rc into lp://qastaging/utah

  1. reset-rc
  2. Merge into dev
Proposed by Max Brustkern
Status: Merged
Merged at revision: 1037
Proposed branch: lp://qastaging/~nuclearbob/utah/reset-rc
Merge into: lp://qastaging/utah
Diff against target: 80 lines (+29/-7)
2 files modified
utah/client/runner.py (+11/-7)
utah/client/tests/test_runner.py (+18/-0)
To merge this branch: bzr merge lp://qastaging/~nuclearbob/utah/reset-rc
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Max Brustkern (community) Needs Resubmitting
Review via email: mp+208246@code.qastaging.launchpad.net

Commit message

Added --reset-rc option to client

Description of the change

This branch adds a --reset-rc option to the utah client. This option is written to rc.local when utah uses rc.local for reboots. In absence of this option, a reset of rc.local will no longer be automatically triggered. This should allow provisioned autorun to work with reboot test cases.

To post a comment you must log in.
lp://qastaging/~nuclearbob/utah/reset-rc updated
1034. By Max Brustkern

Added test

1035. By Max Brustkern

Fixed flake8

Revision history for this message
Andy Doan (doanac) wrote :

I'm basically a +1. I was curious if you thought we could do this with out needing the new option and just auto-detecting how we were launched using logic like we have here:

 http://bazaar.launchpad.net/~nuclearbob/utah/reset-rc/view/head:/utah/client/runner.py#L592

I don't want to cause you a lot of effort doing more testing, but I'll give you bonus points if we could do it like that instead.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Doing that would be better, yeah. I'll look at it today and see if I can figure something out.

lp://qastaging/~nuclearbob/utah/reset-rc updated
1036. By Max Brustkern

Converting _autorun_file to _launched_by

1037. By Max Brustkern

pep257 fix

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Testing a new version now:
http://q-jenkins:8080/job/bootspeed-trusty-desktop-amd64-acer-veriton-03/13/

Revision history for this message
Max Brustkern (nuclearbob) wrote :

We've completed several successful runs, so I'm happy with the testing of the new version. If you'd like to take a look at it again, we can verify it's good to go.

review: Needs Resubmitting
Revision history for this message
Andy Doan (doanac) wrote :

thanks max. this looks like it will be a lot easier to maintain.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches