ubuntu-system-settings

Merge lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test into lp://qastaging/ubuntu-system-settings

add_ringtone_test
Merge into trunk

Proposed by Omer Akram on 2014-05-22

Status:	Superseded
Proposed branch:	lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test
Merge into:	lp://qastaging/ubuntu-system-settings
Diff against target:	419 lines (+252/-8) (has conflicts) 8 files modified plugins/sound/PageComponent.qml (+1/-0) plugins/sound/SoundsList.qml (+7/-0) src/main.cpp (+2/-1) tests/autopilot/ubuntu_system_settings/__init__.py (+116/-6) tests/autopilot/ubuntu_system_settings/fixture_setup.py (+39/-0) tests/autopilot/ubuntu_system_settings/helpers.py (+37/-0) tests/autopilot/ubuntu_system_settings/tests/__init__.py (+7/-1) tests/autopilot/ubuntu_system_settings/tests/test_sound.py (+43/-0) Text conflict in plugins/sound/SoundsList.qml Text conflict in tests/autopilot/ubuntu_system_settings/__init__.py Text conflict in tests/autopilot/ubuntu_system_settings/tests/__init__.py Text conflict in tests/autopilot/ubuntu_system_settings/tests/test_sound.py
To merge this branch:	bzr merge lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Leo Arias (community)			Needs Fixing on 2014-07-16
PS Jenkins bot	continuous-integration		Needs Fixing on 2014-07-15
Sebastien Bacher (community)		2014-05-22	Needs Fixing on 2014-07-15
Review via email: mp+220612@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2014-07-25.

Commit message

adds test to ensure the ringtone can be changed

Revision history for this message

Leo Arias (elopio) wrote on 2014-05-23:

Just please rename this:

+ def ringtone_setting_button_current_value(self):

to:

get_current_value

Nice work, thanks!

review: Approve (code review)

Revision history for this message

Christopher Lee (veebers) wrote on 2014-05-23:

Hi Omer, I'm just being very nosey. Is the sleep on diff line 130 required? Esp. if you're doing a wait_for just after that.

Looks nice and clean :-)

Revision history for this message

Omer Akram (om26er) wrote on 2014-05-23:

> Hi Omer, I'm just being very nosey. Is the sleep on diff line 130 required?
> Esp. if you're doing a wait_for just after that.
>
> Looks nice and clean :-)

Thanks for the comment.

That sleep is required. When you open the ringtone settings page, initially the page is not moving but if the current selected ringtone is at the bottom of the list and not visible on screen, it automatically scrolls down. So we try to workaround that.

Ideally it would always show the selected ringtone at the center whenever the list is opened but currently its not doing that.

Revision history for this message

Omer Akram (om26er) wrote on 2014-05-23:

> Just please rename this:
>
> + def ringtone_setting_button_current_value(self):
>
> to:
>
> get_current_value
>
> Nice work, thanks!

Done!

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-23:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/835/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-23:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/836/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-23:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/837/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-26:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/838/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-06-03:

Thank you for your work, the approach seems fine, CI is unhappy it seems though, could you have a look to that?

review: Needs Fixing

Revision history for this message

Omer Akram (om26er) wrote on 2014-06-04:

Not ready, just changed status for CI.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-04:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/855/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test updated on 2014-06-05

717. By Omer Akram on 2014-06-05: merge trunk
718. By Omer Akram on 2014-06-05: use upstart launch on touch devices to start settings app so that accountservice changes take place.
719. By Omer Akram on 2014-06-05: change ringtones to select

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-05:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/860/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-05:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/861/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test updated on 2014-06-06

720. By Omer Akram on 2014-06-06: use upstart-app-launch to start test application to make app launching consistent and reliable

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-06:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/863/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test updated on 2014-06-06

721. By Omer Akram on 2014-06-06: revert last commit
722. By Omer Akram on 2014-06-06: run rintone tests on phone only, there are a lot of problems with accountsservice in otto

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-06:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/865/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test updated on 2014-06-23

723. By Omer Akram on 2014-06-23: change ringtone to reproduce the bug

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-23:

FAILED: Continuous integration, rev:723
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/886/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1090/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/978/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-amd64-ci/78/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/78/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/78/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1910/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1121/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/886/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test updated on 2014-06-23

724. By Omer Akram on 2014-06-23: adapt for trunk
725. By Omer Akram on 2014-06-23: merge trunk

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-23:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/887/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test updated on 2014-06-30

726. By Omer Akram on 2014-06-30: remove repetition of objectName

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-30:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/907/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test updated on 2014-07-15

727. By Omer Akram on 2014-07-15: merge trunk

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-07-15:

Should that be marked "work in progress"? The CI seems still unhappy there...

Note that https://code.launchpad.net/~elopio/ubuntu-system-settings/refactor_about_tests/+merge/226468 is about the land and that your changes are going to need to be rebased, since there is a conflict when applying those on top of trunk

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-15:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/996/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-16:

I've been able to make it work fixing some things.

First, one second is not enough. And then, it's safest if you also wait for the dragging property.

Instead of:
186 + sleep(1)
187 + list_view.moving.wait_for(False)

sleep(3)
list_view.dragging.wait_for(False)
list_view.moving.wait_for(False)

Then, you will need this branch to land on the toolkit:
https://code.launchpad.net/~canonical-platform-qa/ubuntu-ui-toolkit/fix1342521-find_element_on_top/+merge/226961

Please review it.

Now, it's really important to notice that the need for a sleep is a typical case of a UX bug. For some seconds, the page does nothing. Enough time for the user to start an action. And when the user is just about to click an element on the list or swipe it, the list is swiped by itself making the user click the wrong thing, or just wondering what caused the magic swipe.

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-16:

I reported that bug here: https://bugs.launchpad.net/ubuntu-ux/+bug/1342533
Please add a comment on the sleep with a reference to that bug.

review: Needs Fixing

lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test updated on 2014-07-24

728. By Omer Akram on 2014-07-24: change ringtone to select, get current ringonte by directly talking to dbus, wait a bit more for automoving list
729. By Omer Akram on 2014-07-24: add a fixture to backup ringtone before running the tests

Unmerged revisions

729. By Omer Akram on 2014-07-24: add a fixture to backup ringtone before running the tests
728. By Omer Akram on 2014-07-24: change ringtone to select, get current ringonte by directly talking to dbus, wait a bit more for automoving list
727. By Omer Akram on 2014-07-15: merge trunk
726. By Omer Akram on 2014-06-30: remove repetition of objectName
725. By Omer Akram on 2014-06-23: merge trunk
724. By Omer Akram on 2014-06-23: adapt for trunk
723. By Omer Akram on 2014-06-23: change ringtone to reproduce the bug
722. By Omer Akram on 2014-06-06: run rintone tests on phone only, there are a lot of problems with accountsservice in otto
721. By Omer Akram on 2014-06-06: revert last commit
720. By Omer Akram on 2014-06-06: use upstart-app-launch to start test application to make app launching consistent and reliable

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Omer Akram

Ubuntu Touch System Settings

ubuntu-system-settings

Merge lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test into lp://qastaging/ubuntu-system-settings

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers