Code review comment for lp://qastaging/~om26er/ubuntu-system-settings/add_ringtone_test

Revision history for this message
Leo Arias (elopio) wrote :

I've been able to make it work fixing some things.

First, one second is not enough. And then, it's safest if you also wait for the dragging property.

Instead of:
186 + sleep(1)
187 + list_view.moving.wait_for(False)

sleep(3)
list_view.dragging.wait_for(False)
list_view.moving.wait_for(False)

Then, you will need this branch to land on the toolkit:
https://code.launchpad.net/~canonical-platform-qa/ubuntu-ui-toolkit/fix1342521-find_element_on_top/+merge/226961

Please review it.

Now, it's really important to notice that the need for a sleep is a typical case of a UX bug. For some seconds, the page does nothing. Enough time for the user to start an action. And when the user is just about to click an element on the list or swipe it, the list is swiped by itself making the user click the wrong thing, or just wondering what caused the magic swipe.

« Back to merge proposal