Code review comment for lp://qastaging/~openbmsjsc/openobject-addons/addons-extra-trunk-l10n_vn

Revision history for this message
Gustavo Adrian Marino (gamarino) wrote :

I wish to add something that is not technically wrong, but it could become a potential problem.

You are defining your user account.types on the account.xxxx namespace. I believe that could be a potential cause of problems on multi country databases (that is a multicompany installation with each company using a different template). If all localization templates uses the account.xxx namespace to define their own types, name crashing could become a real problem.

I suggest to keep account.types as locally defined items (that means using the module namespace) in order to prevent the a.m. danger

« Back to merge proposal