Odoo Server (MOVED TO GITHUB)

Code review comment for lp://qastaging/~openerp-dev/openobject-server/6.1-multicorn-al

  1. 6.1-multicorn-al
  2. Merge into 6.1
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

Is --multiprocess a standard option name? I dislike it, because its name suggests a *boolean* option. Make uses --jobs (shortcut -j) for the same purpose, and I think that a bunch of tools use --jobs. I also saw --processes, that I find nice and unambiguous.

Some technical remarks:
- Remove line 375 in diff: apparently openerp.multi_process is not used anywhere else.
- Lines 625, 694 in diff: use "True" instead of "1".
- The class names "Unicron" and "Unicorn" are only a typo away. This confused me the first time I saw it. I suggest to increase their typo distance, and use something like "UnicornCron" or "UniCRON" to reduce confusion.

Raphael

Reply

« Back to merge proposal