Code review comment for lp://qastaging/~openerp-dev/openobject-server/6.1-multicorn-al
Revision history for this message
| Antony Lesuisse (OpenERP) (al-openerp) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> Is --multiprocess a standard option name? I dislike it, because its name
> suggests a *boolean* option. Make uses --jobs (shortcut -j) for the same
> purpose, and I think that a bunch of tools use --jobs. I also saw
> --processes, that I find nice and unambiguous.
--workers ok ?
> Some technical remarks:
> - Remove line 375 in diff: apparently openerp.
> anywhere else.
it is used, it enables db signaling for registry reload
> - Lines 625, 694 in diff: use "True" instead of "1".
> - The class names "Unicron" and "Unicorn" are only a typo away. This confused
> me the first time I saw it. I suggest to increase their typo distance, and
> use something like "UnicornCron" or "UniCRON" to reduce confusion.
It's was pun, i plan to rename them to HTTPWorker and CronWorker before the merge. :)