Code review comment for lp://qastaging/~osomon/unity-2d/custom-quicklists-dynamic

Revision history for this message
Olivier Tilloy (osomon) wrote :

> 208 LauncherApplicationsList::onRemoteEntryUpdated(QString
> applicationURI, QMap<QString, QVariant> properties)
> 209 {
> 210 + QString sender = message().service();
>
> For safety I would would check the result of calledFromDBus() before
> proceeding to access message()

This is true on principle (better safe than sorry). However onRemoteEntryUpdated is a private slot and it is only connected to D-Bus signals, so we are guaranteed that it is actually called from DBus.

« Back to merge proposal