Code review comment for lp://qastaging/~osomon/unity-2d/dnd2

Revision history for this message
Olivier Tilloy (osomon) wrote :

> We ship Qt 4.7.1 in Natty, so you should already be able to use
> DeclarativeDragDropEvent* instead of QObject*.

Fixed.

> I think you don't need to call setAccepted() in drop methods (onDrop() or
> dropEvent()). It only matters in drag methods (onDragEnter(),
> dragEnterEvent(), ondragMove(), dragMoveEvent()).

Verified and fixed, thanks for the tip!

> Usual nitpick: "}\nelse {" => "} else {" :)

Fixed too. I’ll never get used to it :/

All your comments have been addressed except the C++ to QML to C++ roundtrip, for which I welcome implementation ideas.

« Back to merge proposal