webbrowser-app

Merge lp://qastaging/~osomon/webbrowser-app/oxide-context-menu into lp://qastaging/webbrowser-app

oxide-context-menu
Merge into trunk

Proposed by Olivier Tilloy on 2015-08-21

Status:

Merged

Approved by:

Olivier Tilloy on 2015-08-27

Approved revision:

1142

Merged at revision:

1152

Proposed branch:

lp://qastaging/~osomon/webbrowser-app/oxide-context-menu

Merge into:

lp://qastaging/webbrowser-app

Diff against target:

2579 lines (+1390/-690)

34 files modified

debian/control (+2/-12)
debian/qtdeclarative5-ubuntu-web-plugin-assets.install (+0/-1)
debian/rules (+0/-4)
doc/WebView.qdoc (+44/-5)
src/Ubuntu/Web/CMakeLists.txt (+0/-3)
src/Ubuntu/Web/Selection.qml (+0/-161)
src/Ubuntu/Web/SelectionHandle.qml (+0/-47)
src/Ubuntu/Web/UbuntuWebView02.qml (+60/-156)
src/Ubuntu/Web/selection02.js (+2/-131)
src/app/CMakeLists.txt (+1/-0)
src/app/FileExtensionMapper.js (+11/-7)
src/app/FilePickerDialog.qml (+2/-2)
src/app/WebViewImpl.qml (+20/-9)
src/app/actions/Cut.qml (+23/-0)
src/app/actions/Erase.qml (+23/-0)
src/app/actions/Paste.qml (+23/-0)
src/app/actions/Redo.qml (+23/-0)
src/app/actions/SaveLink.qml (+23/-0)
src/app/actions/SelectAll.qml (+23/-0)
src/app/actions/Undo.qml (+23/-0)
src/app/browserapplication.cpp (+9/-0)
src/app/mime-database.cpp (+33/-0)
src/app/mime-database.h (+39/-0)
src/app/webbrowser/Browser.qml (+103/-26)
src/app/webbrowser/ContextMenuMobile.qml (+168/-0)
src/app/webbrowser/ContextMenuWide.qml (+158/-0)
src/app/webbrowser/assets/stock_link.svg (+164/-0)
src/app/webcontainer/WebViewImplOxide.qml (+42/-5)
tests/autopilot/webbrowser_app/emulators/browser.py (+33/-16)
tests/autopilot/webbrowser_app/tests/http_server.py (+28/-0)
tests/autopilot/webbrowser_app/tests/test_contextmenu.py (+177/-0)
tests/autopilot/webbrowser_app/tests/test_selection.py (+0/-92)
tests/unittests/qml/tst_FileExtensionMapper.qml (+39/-0)
tests/unittests/qml/tst_UbuntuWebView02.qml (+94/-13)

To merge this branch:

bzr merge lp://qastaging/~osomon/webbrowser-app/oxide-context-menu

Related bugs:

Bug #1264493: No Paste option in web page entries	High	Fix Released
Bug #1326070: Add support for context menus	High	Fix Released
Bug #1438046: Can't download protected images	Medium	Fix Released
Bug #1450430: Text selection box drawn in wrong place	High	Fix Released
Bug #1471181: Test that WebContextMenu position property is in the correct coordinate space	Medium	Fix Released
Bug #1477309: right click menu looks disabled, change the styling	Medium	Fix Released
Bug #1477310: [convergence] Save image option not appearing when right clicking on image	Medium	Fix Released
Bug #1477315: [convergence] Context menu displayed in wrong spot on desktop when invoked over links (not close to the link)	High	Fix Released
Bug #1485984: webbrowser_app.tests.test_selection.TestSelection.* flaky since oxide 1.8	High	Fix Released
Bug #1487090: Download initiated from context menu’s saveLink/saveMedia doesn’t expose a mime type	Undecided	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ken VanDine			Approve on 2015-08-27
Ugo Riboni (community)		2015-08-21	Approve on 2015-08-27
PS Jenkins bot	continuous-integration		Approve on 2015-08-26
Review via email: mp+268786@code.qastaging.launchpad.net

Commit message

Use the contextMenu API new in oxide 1.8.
Update the visuals for the context menu in narrow and wide form factors.
Add text editing commands to the context menu.
Add unit and autopilot tests for the context menu features.
This bumps the runtime dependency of webapp-container and qtdeclarative5-ubuntu-web-plugin on liboxideqt-qmlplugin to 1.8.
This also removes the qtdeclarative5-ubuntu-web-plugin-assets binary package, which contained only one PNG asset which is not used anywhere any longer.