Code review comment for lp://qastaging/~osomon/webbrowser-app/oxide-context-menu

Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks for your thorough review. I replied all your comments inline (and updated the code where relevant). The only pending task is to update the code to use QMimeDatabase per your recommendation, which I’m working on now.

I removed the selection mechanism as part of this MR because in fact this new context menu implementation broke it even further (it had already been quite broken since its initial implementation, but this made things slightly worse, and I spent way too much time trying to fix it). In that regard it made sense to remove it now.

« Back to merge proposal