Merge ~pappacena/launchpad:oci-recipe-cascade-delete-bugfix into launchpad:master

Proposed by Thiago F. Pappacena
Status: Merged
Approved by: Thiago F. Pappacena
Approved revision: 0acec176975313619a2b0fd93949f487f19e8c58
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~pappacena/launchpad:oci-recipe-cascade-delete-bugfix
Merge into: launchpad:master
Diff against target: 74 lines (+9/-7)
3 files modified
lib/lp/oci/model/ocirecipe.py (+2/-2)
lib/lp/oci/tests/test_ocirecipe.py (+4/-2)
lib/lp/testing/factory.py (+3/-3)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+398711@code.qastaging.launchpad.net

Commit message

LP: #1916605 - Fixing cascading deletion problem on OCIRecipe

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

LGTM, though could you adjust the commit message to use the form mentioned in https://help.launchpad.net/Code/Git#Linking_to_bugs since that's what I tend to search for when preparing deployments? I.e. "LP: #1916605" somewhere.

review: Approve
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

Changed the commit message. Landing this MP.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.