Merge lp://qastaging/~patrick-crews/drizzle/drizzle_dump_restore_test into lp://qastaging/~drizzle-trunk/drizzle/development
| Status: | Merged |
|---|---|
| Merge reported by: | Patrick Crews |
| Merged at revision: | not available |
| Proposed branch: | lp://qastaging/~patrick-crews/drizzle/drizzle_dump_restore_test |
| Merge into: | lp://qastaging/~drizzle-trunk/drizzle/development |
| Diff against target: |
331 lines (+254/-24) 5 files modified
tests/include/diff_tables.inc (+22/-24) tests/include/drizzledump.inc (+45/-0) tests/r/drizzledump_restore.result (+83/-0) tests/t/drizzledump_restore.test (+91/-0) tests/test-run.pl (+13/-0) |
| To merge this branch: | bzr merge lp://qastaging/~patrick-crews/drizzle/drizzle_dump_restore_test |
| Related bugs: | |
| Related blueprints: |
Increase testing of dump and restore
(Medium)
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Monty Taylor | Needs Fixing | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2010-05-20.
Description of the change
I ported a simple test of dump/restore that I had added to MySQL some time ago. It is drizzledump_restore
This test could use some expanded scenarios, but it does verify that we can dump and restore a table.
Altered test-run.pl so that we can call the drizzle client from within tests ($DRIZZLE), which was needed for the restore portion of the test.
Included a partial port of MySQL Bug#51057 - Weak code in diff_tables.inc can lead to 100% CPU consumption. If one of the tables to be compared did not exist, the test would timeout and waste time and resources.
Ran into some issues with diff_tables and ORDINAL_POSITION, but I suspect this was not needed and the new test is the only one that actually uses this include file.
| Patrick Crews (patrick-crews) wrote | # |
| Stewart Smith (stewart) wrote | # |
Looks great!
Two things...
First, it looks like you forgot to add the new test files...
Second, just go ahead and delete the code you commented out in diff_tables. If we need it, we can also pull it from a previous version.