Drizzle

Merge lp://qastaging/~patrick-crews/drizzle/drizzle_dump_restore_test into lp://qastaging/~drizzle-trunk/drizzle/development

  1. drizzle_dump_restore_test
  2. Merge into development
Proposed by Monty Taylor
Status: Merged
Merged at revision: 1565
Proposed branch: lp://qastaging/~patrick-crews/drizzle/drizzle_dump_restore_test
Merge into: lp://qastaging/~drizzle-trunk/drizzle/development
Diff against target: 287 lines (+219/-43)
4 files modified
tests/include/diff_tables.inc (+0/-43)
tests/include/drizzledump.inc (+45/-0)
tests/r/drizzledump_restore.result (+83/-0)
tests/t/drizzledump_restore.test (+91/-0)
To merge this branch: bzr merge lp://qastaging/~patrick-crews/drizzle/drizzle_dump_restore_test
Reviewer Review Type Date Requested Status
Monty Taylor Approve
Brian Aker Pending
Review via email: mp+25695@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2010-05-19.

Description of the change

I ported a simple test of dump/restore that I had added to MySQL some time ago. It is drizzledump_restore

This test could use some expanded scenarios, but it does verify that we can dump and restore a table.

Altered test-run.pl so that we can call the drizzle client from within tests ($DRIZZLE), which was needed for the restore portion of the test.

Included a partial port of MySQL Bug#51057 - Weak code in diff_tables.inc can lead to 100% CPU consumption. If one of the tables to be compared did not exist, the test would timeout and waste time and resources.

Ran into some issues with diff_tables and ORDINAL_POSITION, but I suspect this was not needed and the new test is the only one that actually uses this include file.

To post a comment you must log in.
Revision history for this message
Monty Taylor (mordred) wrote : Posted in a previous version of this proposal

Looks great!

Two things...

First, it looks like you forgot to add the new test files...

Second, just go ahead and delete the code you commented out in diff_tables. If we need it, we can also pull it from a previous version.

review: Needs Fixing
Revision history for this message
Patrick Crews (patrick-crews) wrote : Posted in a previous version of this proposal

Sorry about the omission of the new files. My bzr skills are have gathered some dust. Things are fixed and polished - removed the unneeded code from diff_tables.inc and added the new files

Revision history for this message
Stewart Smith (stewart) wrote : Posted in a previous version of this proposal

On Thu, 20 May 2010 03:40:54 -0000, Patrick Crews <email address hidden> wrote:
> Sorry about the omission of the new files. My bzr skills are have
> gathered some dust. Things are fixed and polished - removed the
> unneeded code from diff_tables.inc and added the new files

'bzr status' can tell you what's around. useful to run before
committing, it'll tell you unknown files (taht you've probably forgotten
to add)

--
Stewart Smith

Revision history for this message
Monty Taylor (mordred) wrote :

Great. W00t.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.