Code review comment for lp://qastaging/~percona-core/percona-xtradb-cluster/bug-1402338-5.5

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Looks good except:

- spurious indentation change for "int ret= 0;";
- code in wsrep_mysqld.cc follows MySQL coding guidelines, not InnoDB ones. This means "lex= ..." instead of "lex = ...", and the following "if ... else ..." formatting:

if ()
{
  ...
}
else
{
  ...
}

review: Needs Fixing

« Back to merge proposal