Code review comment for lp://qastaging/~pfalcon/linaro-android-build-tools/final-build-step

Revision history for this message
Deepti B. Kalakeri (deeptik) wrote :

On Thu, Jun 14, 2012 at 3:35 PM, Paul Sokolovsky <<email address hidden>
> wrote:

> > Paul, thanks for working on this. Is newline required before </command>
> like that?
>
> Well, I just copied that from actual Jenkins config, and yes, it's
> apparently encodes newline between commands. In this specific case it is
> trailing, so might be possible to fold, or maybe not, depends on how
> Jenkins interprets it.
>

I have verified this and jenkins interprets it correctly even if </command>
is in the same line.

>
> --
>
> https://code.launchpad.net/~pfalcon/linaro-android-build-tools/final-build-step/+merge/109648<https://code.launchpad.net/%7Epfalcon/linaro-android-build-tools/final-build-step/+merge/109648>
> Your team Linaro Infrastructure is requested to review the proposed merge
> of lp:~pfalcon/linaro-android-build-tools/final-build-step into
> lp:linaro-android-build-tools.
>

--
Thanks and Regards,
Deepti

« Back to merge proposal