Code review comment for lp://qastaging/~pfalcon/linaro-android-build-tools/getpass

Revision history for this message
Deepti B. Kalakeri (deeptik) wrote :

On Tue, May 22, 2012 at 3:42 PM, Paul Sokolovsky <<email address hidden>
> wrote:

> Ok, added --url= parameter. Consequently, for ci.linaro.org migration,
> following command should be used:
>
> $ ./mangle-jobs --url=http://localhost:8080/jenkins/ --user=<Jenkins
> username> build-expiration-set.mangle >mangle.diff
>
> And yes, the script is to be run directly on the Jenkins master host.
>
> --
>
> https://code.launchpad.net/~pfalcon/linaro-android-build-tools/getpass/+merge/106628<https://code.launchpad.net/%7Epfalcon/linaro-android-build-tools/getpass/+merge/106628>
> You are reviewing the proposed merge of
> lp:~pfalcon/linaro-android-build-tools/getpass into
> lp:linaro-android-build-tools.
>

Looks good. Just one thing which I forgot to mention previously, the
optparse <http://docs.python.org/library/optparse.html#module-optparse>module
is deprecated and will not be developed further, so should we use
the argparse instead ?

--
Thanks and Regards,
Deepti

« Back to merge proposal