Code review comment for lp://qastaging/~pfalcon/linaro-android-build-tools/validate-build-conf

Revision history for this message
Georgy Redkozubov (gesha) wrote :

At least following 2 errors were found:

1) convert_config_to_shell() takes 1 argument in definition, 2 was given: config = convert_config_to_shell(config_text, get_slave_type())

   Looks like you have mixed up 2 functions, please move get_slave_type() form first to second:
    config = convert_config_to_shell(config_text, get_slave_type())
    try:
        validate_config(config)

2) global name 'cfg' is not defined
     for l in cfg.split("\n"):
   You should use config_text.split("\n") instead

review: Needs Fixing

« Back to merge proposal