Code review comment for lp://qastaging/~phablet-team/network-manager/lp1425172

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Logic looks fine, but this patch is missing the appropriate DEP-3 patch tags. Could you please fix that?

Is it a patch cherry-picked from upstream or did you make the code changes yourself? This should be reflected in the patch tags. If it's a cherry-pick, the ideal is to use the patch as-is, as the git patch from format-patch will already contain all the necessary information.

review: Needs Fixing

« Back to merge proposal