Code review comment for lp://qastaging/~phablet-team/network-manager/ofono-rm-unused-code

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Changeset is fine, but given that the unused/commented code is obvious and straightforward, I'd rather avoid making cosmetic changes two weeks away from Vivid release, even when bundled with bugfixes. I don't see why it couldn't wait two more weeks and land in the next release cycle.

Call me extra careful, but it's *very* late in the release so I'd defer the decision of landing this despite it being cosmetic changes to the release team. Could you please bring it up to them?

review: Abstain

« Back to merge proposal