Merge lp://qastaging/~phablet-team/notes-app/inline-desktop-i18n into lp://qastaging/notes-app
Proposed by
Ugo Riboni
Status: | Approved | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Olivier Tilloy | ||||||||||||
Approved revision: | 293 | ||||||||||||
Proposed branch: | lp://qastaging/~phablet-team/notes-app/inline-desktop-i18n | ||||||||||||
Merge into: | lp://qastaging/notes-app | ||||||||||||
Diff against target: |
197 lines (+44/-53) 6 files modified
.bzrignore (+3/-0) CMakeLists.txt (+15/-18) NotesApp.qmlproject (+0/-25) notes-app.desktop.in.in (+4/-3) po/CMakeLists.txt (+15/-4) po/com.ubuntu.notes.pot (+7/-3) |
||||||||||||
To merge this branch: | bzr merge lp://qastaging/~phablet-team/notes-app/inline-desktop-i18n | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Tilloy | Approve | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
David Planella (community) | Approve | ||
Review via email:
|
Description of the change
Update the desktop file for inline i18n
To post a comment you must log in.
Unmerged revisions
- 293. By Ugo Riboni
-
Remove a duplicate line and a line that is unnecessary
- 292. By Ugo Riboni
-
Show all source when loading the cmake project, and remove the qmlproject file which serves no purpose any more
- 291. By Ugo Riboni
-
Update the pot file
- 290. By Ugo Riboni
-
Generate inline desktop translations
Looks good to me at a glance. Just one inline comment.