Code review comment for lp://qastaging/~pkunal-parmar/ubuntu-calendar-app/CalManagement

Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Albert ran this under valgrind and found it's still crashing in qtorganized-eds

==16142== Invalid write of size 8
==16142== at 0x230989DA: RequestData::cancel() (in /usr/lib/x86_64-linux-gnu/qt5/plugins/organizer/libqtorganizer_eds.so)
==16142== by 0x2308858A: QOrganizerEDSEngine::cancelRequest(QtOrganizer::QOrganizerAbstractRequest*) (in /usr/lib/x86_64-linux-gnu/qt5/plugins/organizer/libqtorganizer_eds.so)
==16142== by 0x1EC266FA: QtOrganizer::QOrganizerAbstractRequest::cancel() (in /usr/lib/x86_64-linux-gnu/libQt5Organizer.so.5.0.0)
==16142== by 0x21F3A322: ??? (in /usr/lib/x86_64-linux-gnu/qt5/qml/QtOrganizer/libdeclarative_organizer.so)
==16142== by 0x21F3AA53: ??? (in /usr/lib/x86_64-linux-gnu/qt5/qml/QtOrganizer/libdeclarative_organizer.so)
==16142== by 0x21F42DC4: ??? (in /usr/lib/x86_64-linux-gnu/qt5/qml/QtOrganizer/libdeclarative_organizer.so)
==16142== by 0x6ACF22D: QObject::event(QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==16142== by 0x5B03C8B: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
==16142== by 0x5B08E55: QApplication::notify(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
==16142== by 0x6AA6C2C: QCoreApplication::notifyInternal(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==16142== by 0x6AA8E06: QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==16142== by 0x6AF3CD2: ??? (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==16142== Address 0x33ab75c8 is 56 bytes inside a block of size 96 free'd
==16142== at 0x4C2C2BC: operator delete(void*) (vg_replace_malloc.c:503)
==16142== by 0x23314374: ??? (in /usr/lib/libecal-1.2.so.16.0.0)
==16142== by 0x23319FA1: ??? (in /usr/lib/libecal-1.2.so.16.0.0)
==16142== by 0x1410EEF6: g_simple_async_result_complete (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.4000.0)
==16142== by 0x1410EF78: complete_in_idle_cb_for_thread (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.4000.0)
==16142== by 0x831DCE4: g_main_context_dispatch (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4000.0)
==16142== by 0x831E047: g_main_context_iterate.isra.24 (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4000.0)
==16142== by 0x831E0EB: g_main_context_iteration (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4000.0)
==16142== by 0x6AF398B: QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==16142== by 0x23085FC6: QOrganizerEDSEngine::waitForRequestFinished(QtOrganizer::QOrganizerAbstractRequest*, int) (in /usr/lib/x86_64-linux-gnu/qt5/plugins/organizer/libqtorganizer_eds.so)
==16142== by 0x230989D9: RequestData::cancel() (in /usr/lib/x86_64-linux-gnu/qt5/plugins/organizer/libqtorganizer_eds.so)
==16142== by 0x2308858A: QOrganizerEDSEngine::cancelRequest(QtOrganizer::QOrganizerAbstractRequest*) (in /usr/lib/x86_64-linux-gnu/qt5/plugins/organizer/libqtorganizer_eds.so)

« Back to merge proposal