Code review comment for lp://qastaging/~pkunal-parmar/ubuntu-calendar-app/CalManagement

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> I modified the code, now after changing the filter, calendar does not freeze.

What exactly do you want with these filters, they does not look correct for me:

Union filter will list events that matches with all filters and you are using a filter that conflict with each other.

        DetailFieldFilter{
            id: eventFilter
            detail: Detail.ItemType;
            field: Type.FieldType
            value: Type.Event
            matchFlags: Filter.MatchExactly
        }

        DetailFieldFilter{
            id: eventOccurenceFilter
            detail: Detail.ItemType;
            field: Type.FieldType
            value: Type.EventOccurrence
            matchFlags: Filter.MatchExactly
        }

A event can only be one type Type.EventOccurrence or Type.Event.

« Back to merge proposal