Merge lp://qastaging/~psusi/ubuntu/utopic/upstart/fix-reboot into lp://qastaging/ubuntu/utopic/upstart
Proposed by
Phillip Susi
| Status: | Rejected |
|---|---|
| Rejected by: | Dimitri John Ledkov |
| Proposed branch: | lp://qastaging/~psusi/ubuntu/utopic/upstart/fix-reboot |
| Merge into: | lp://qastaging/ubuntu/utopic/upstart |
| Diff against target: |
26 lines (+8/-0) 2 files modified
debian/changelog (+7/-0) util/reboot.c (+1/-0) |
| To merge this branch: | bzr merge lp://qastaging/~psusi/ubuntu/utopic/upstart/fix-reboot |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Dimitri John Ledkov (community) | Disapprove | ||
|
Review via email:
|
|||
Description of the change
The addition of the REBOOTCOMMAND support made a mistake. The argument is only supposed to be honored in conjunction with the --force flag. Without --force, it mistakenly caused shutdown to be called but without the -r switch, so instead of rebooting, it went to single user mode.
To post a comment you must log in.
Unmerged revisions
- 1565. By Phillip Susi
-
Fix use of REBOOTCOMMAND argument to not bring the system
down to single user mode (LP: #1174272)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
As discussed on IRC, please use lp:upstart for patches against upstart.
The fix proposed is in the "exec shutdown" codepath, which will then prevent in the future adding rebootcommand passing to shutdown command.
Instead, it's better to fix REBOOTCOMMAND mode assignment in the first place.
See https:/