Code review comment for lp://qastaging/~psusi/ubuntu/utopic/upstart/fix-reboot

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

As discussed on IRC, please use lp:upstart for patches against upstart.

The fix proposed is in the "exec shutdown" codepath, which will then prevent in the future adding rebootcommand passing to shutdown command.

Instead, it's better to fix REBOOTCOMMAND mode assignment in the first place.

See https://code.launchpad.net/~xnox/upstart/reboot-fix/+merge/219007

review: Disapprove

« Back to merge proposal