Code review comment for lp://qastaging/~rackspace-titan/nova/osapi-servers-cleanup-p1

Revision history for this message
Brian Waldon (bcwaldon) wrote :

The pep8 and explanation stuff is fine. I'm fine with the return-code fixes as long as they match the spec. I don't even like using 422, as is a webdav-specific and not in the core set of http exceptions.

I'm curious if we actually need the context object. I have no idea what it is doing for us.

I'm not too crazy about adding the reservation_id property to wsgi.Request. It doesn't seem to get used very much and it doesn't belong on the request object if the majority of the codes doesn't use it.

Also, you changed single quotes to double quotes. Personally, I use single quotes for tokens (mainly dict keys) and double quotes for things like HTTPException explanations. What is your take on this?

« Back to merge proposal