Merge lp://qastaging/~ralsina/ubuntuone-control-panel/fix-983665 into lp://qastaging/ubuntuone-control-panel

Proposed by Roberto Alsina
Status: Merged
Approved by: Roberto Alsina
Approved revision: 326
Merged at revision: 323
Proposed branch: lp://qastaging/~ralsina/ubuntuone-control-panel/fix-983665
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 90 lines (+39/-1)
4 files modified
data/qt/images.qrc (+4/-0)
data/qt/ubuntuone-rtl.qss (+27/-0)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+4/-1)
ubuntuone/controlpanel/gui/qt/main/tests/test_main.py (+4/-0)
To merge this branch: bzr merge lp://qastaging/~ralsina/ubuntuone-control-panel/fix-983665
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
Diego Sarmentero (community) Approve
Review via email: mp+105737@code.qastaging.launchpad.net

Commit message

- Reverse styling for web buttons in RTL locales (Fixes LP:983665)

Description of the change

Fix button styling for LTR locales.

To test:

PYTHONPATH=. bin/ubuntuone-control-panel-qt -reversed

Compare to nightlies:

ubuntuone-control-panel-qt -reversed

Will attach before-after in comment

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve
Revision history for this message
Alejandro J. Cura (alecu) wrote :

+1

review: Approve
Revision history for this message
Alejandro J. Cura (alecu) wrote :

btw: Great work fixing every RTL detail!

Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches