Merge lp://qastaging/~ralsina/ubuntuone-control-panel/fix_908888 into lp://qastaging/ubuntuone-control-panel

Proposed by Roberto Alsina
Status: Merged
Approved by: Roberto Alsina
Approved revision: 254
Merged at revision: 248
Proposed branch: lp://qastaging/~ralsina/ubuntuone-control-panel/fix_908888
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 142 lines (+44/-12)
2 files modified
ubuntuone/controlpanel/gui/qt/systray.py (+14/-3)
ubuntuone/controlpanel/gui/qt/tests/test_systray.py (+30/-9)
To merge this branch: bzr merge lp://qastaging/~ralsina/ubuntuone-control-panel/fix_908888
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Approve
Roman Yepishev (community) fieldtest Approve
Review via email: mp+86920@code.qastaging.launchpad.net

Commit message

When selecting "Quit Ubuntu One" from the tray context menu, shutdown syncdaemon.

Description of the change

When selecting "Quit Ubuntu One" from the tray context menu, shutdown syncdaemon.

To post a comment you must log in.
Revision history for this message
Roman Yepishev (rye) wrote :

Now when Ubuntu One control panel's quit systray menu item is selected, ubuntuone-syncdaemon.exe quits.
ubuntu-sso-login keeps working.

<rye> ralsina, hm, ubuntu-sso-login.exe keeps working though
<ralsina> rye: yes
<rye> ralsina, but syncdaemon is stopped, true
<ralsina> rye: I am not sure we even want to stop it
<ralsina> rye: cool

review: Approve (fieldtest)
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

looks ok.

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches