Merge lp://qastaging/~ralsina/ubuntuone-control-panel/kibblebits into lp://qastaging/ubuntuone-control-panel

Proposed by Roberto Alsina
Status: Merged
Approved by: Alejandro J. Cura
Approved revision: 323
Merged at revision: 324
Proposed branch: lp://qastaging/~ralsina/ubuntuone-control-panel/kibblebits
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 105 lines (+13/-21)
4 files modified
data/qt/preferences.ui (+6/-14)
ubuntuone/controlpanel/gui/__init__.py (+1/-1)
ubuntuone/controlpanel/gui/qt/preferences.py (+5/-4)
ubuntuone/controlpanel/gui/qt/tests/test_preferences.py (+1/-2)
To merge this branch: bzr merge lp://qastaging/~ralsina/ubuntuone-control-panel/kibblebits
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
Diego Sarmentero (community) Approve
Review via email: mp+105821@code.qastaging.launchpad.net

Commit message

 - Replaced "Kilobits per second" labels with units in the spinboxes (Fixes lp:984484)

To post a comment you must log in.
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Works as expected, tests pass, plus... it looks *much* nicer!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches