Merge lp://qastaging/~ralsina/ubuntuone-control-panel/minus-one-is-the-loneliest-number into lp://qastaging/ubuntuone-control-panel
Proposed by
Roberto Alsina
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Brian Curtin | ||||
| Approved revision: | 326 | ||||
| Merged at revision: | 325 | ||||
| Proposed branch: | lp://qastaging/~ralsina/ubuntuone-control-panel/minus-one-is-the-loneliest-number | ||||
| Merge into: | lp://qastaging/ubuntuone-control-panel | ||||
| Diff against target: |
380 lines (+88/-144) 5 files modified
data/qt/preferences.ui (+43/-17) data/qt/ubuntuone.qss (+7/-0) ubuntuone/controlpanel/gui/__init__.py (+0/-2) ubuntuone/controlpanel/gui/qt/preferences.py (+14/-50) ubuntuone/controlpanel/gui/qt/tests/test_preferences.py (+24/-75) |
||||
| To merge this branch: | bzr merge lp://qastaging/~ralsina/ubuntuone-control-panel/minus-one-is-the-loneliest-number | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brian Curtin (community) | Approve | ||
| Diego Sarmentero (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Improved the UX for the bandwidth settings (Fixes lp:847227).
Description of the change
* Removed the warning 'Please note that your files will not sync if you set your bandwidth to 0' which was not even true
* Enable/disable the spinboxes when you check/uncheck the matching checkbox
* Made the minimum bandwidth value 1, removing the bogus -1 and 0 (it still saves -1 to mean disabled)
- Improved the UX for the bandwidth settings (Fixes lp:847227).
To post a comment you must log in.
Revision history for this message
| Brian Curtin (brian.curtin) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1