Ubuntu One Control Panel

Merge lp://qastaging/~ralsina/ubuntuone-control-panel/no-scroll-overlay into lp://qastaging/ubuntuone-control-panel

  1. no-scroll-overlay
  2. Merge into trunk
Proposed by Roberto Alsina
Status: Merged
Approved by: Roberto Alsina
Approved revision: 342
Merged at revision: 338
Proposed branch: lp://qastaging/~ralsina/ubuntuone-control-panel/no-scroll-overlay
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 72 lines (+37/-0)
2 files modified
ubuntuone/controlpanel/gui/qt/main/__init__.py (+10/-0)
ubuntuone/controlpanel/gui/qt/main/tests/test_main.py (+27/-0)
To merge this branch: bzr merge lp://qastaging/~ralsina/ubuntuone-control-panel/no-scroll-overlay
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
dobey (community) Approve
Review via email: mp+117757@code.qastaging.launchpad.net

Commit message

 - Prevented loading of the scrollbar overlay (Fix LP:1007421).

Description of the change

Manipulate GTK_MODULES so that the scrollbar overlay that breaks Qt apps is not loaded.

To test IRL, start u1cp on Quantal and see if you can see any devices or folders. If you can, the fix worked.

To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

Can you please add a comment why we're doing this here, and include the LP:BUGNO for the bug?

review: Needs Fixing
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Please add tests, and move this code inside the main module.

review: Needs Fixing
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Looks good; tests pass on Precise and Windows 7.

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches