Merge lp://qastaging/~ralsina/ubuntuone-control-panel/quit-quit-quit into lp://qastaging/ubuntuone-control-panel

Proposed by Roberto Alsina
Status: Merged
Approved by: Natalia Bidart
Approved revision: 270
Merged at revision: 268
Proposed branch: lp://qastaging/~ralsina/ubuntuone-control-panel/quit-quit-quit
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 32 lines (+14/-0)
2 files modified
ubuntuone/controlpanel/gui/qt/gui.py (+4/-0)
ubuntuone/controlpanel/gui/qt/tests/test_gui.py (+10/-0)
To merge this branch: bzr merge lp://qastaging/~ralsina/ubuntuone-control-panel/quit-quit-quit
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
dobey (community) Approve
Review via email: mp+95020@code.qastaging.launchpad.net

Commit message

- Added keyboard shortcuts for quitting the control panel (LP: #900753).

Description of the change

Add keyboard shortcuts for quitting the control panel (Ctrl+w and Ctrl+q).

To test IRL, start it and press Ctrl+q (or Ctrl+w)

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
268. By Roberto Alsina

close the window instead of quitting the app

269. By Roberto Alsina

moved stuff to MainWindow

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Could you please remove the leftover in diff line 8?

+ quit_action = None

Thanks!

review: Needs Fixing
270. By Roberto Alsina

removed leftover

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Looks great!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches