Merge lp://qastaging/~ralsina/ubuntuone-control-panel/switch-baby-switch into lp://qastaging/ubuntuone-control-panel

Proposed by Roberto Alsina
Status: Merged
Approved by: Roberto Alsina
Approved revision: 365
Merged at revision: 363
Proposed branch: lp://qastaging/~ralsina/ubuntuone-control-panel/switch-baby-switch
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 46 lines (+17/-6)
2 files modified
ubuntuone/controlpanel/gui/qt/controlpanel.py (+9/-6)
ubuntuone/controlpanel/gui/qt/tests/test_controlpanel.py (+8/-0)
To merge this branch: bzr merge lp://qastaging/~ralsina/ubuntuone-control-panel/switch-baby-switch
Reviewer Review Type Date Requested Status
Brian Curtin (community) Approve
Diego Sarmentero (community) Approve
Review via email: mp+128559@code.qastaging.launchpad.net

Commit message

- Switch to folders tab only hen credentials are not found (Fixes lp:1063904).

Description of the change

This branch fixes the --switch-to option. To test IRL, run u1cp with the "--switch-to=devices" option (or any other tabname) and it should work.

Also important is that it should not break the following behaviour: when you remove your device and login again, you should end in the "folders" tab, not in the "devices" tab.

To test that: start u1cp, remove your device, then login again (without exiting u1cp) and you should end in the folders tab.

To post a comment you must log in.
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve
Revision history for this message
Brian Curtin (brian.curtin) wrote :

Looks ok to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches