Merge lp://qastaging/~raphink/byobu/acl into lp://qastaging/byobu
Proposed by
Raphaël Pinson
Status: | Needs review |
---|---|
Proposed branch: | lp://qastaging/~raphink/byobu/acl |
Merge into: | lp://qastaging/byobu |
Diff against target: |
266 lines (+218/-4) 1 file modified
usr/bin/byobu-config (+218/-4) |
To merge this branch: | bzr merge lp://qastaging/~raphink/byobu/acl |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Dustin Kirkland | Needs Fixing | ||
Review via email: mp+18205@code.qastaging.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 911. By Raphaël Pinson <raphink@rpinson>
-
Reimplement "Remove all rights" in updateacl
- 910. By Raphaël Pinson <raphink@rpinson>
-
Fix execuseracl call
- 909. By Raphaël Pinson <raphink@rpinson>
-
Nicer check for setuid root
- 908. By Raphaël Pinson <raphink@rpinson>
-
Check for setuid root to allow multiuser functions
- 907. By Raphaël Pinson <raphink@rpinson>
-
No need to remove acls from the "Add ACL" menu
- 906. By Raphaël Pinson <raphink@rpinson>
-
Dump ACL when made and allow to modify them
- 905. By Raphaël Pinson <raphink@rpinson>
-
Main menu has height 10 now
- 904. By Raphaël Pinson <raphink@rpinson>
-
Added Remove all ACL button
- 903. By Raphaël Pinson <raphink@rpinson>
-
Add ACL menu
Hi :-Dustin,
This branch adds a menu entry in byobu-config to deal with basic ACLs.
Ideally, I wanted to have a menu with existing ACLs to modify them, and another one to add new ACLs. As it turned out, I couldn't find out how to read the current ACLs for the screen. The only command I've found is ^A:displays, but it's a paged display that cannot be parsed, and it doesn't list all ACLs. As a result, you have to specify the full ACLs for every change.
To apply the ACLs, I chose to use a tempfile since there were a few commands to launch. You might prefer to launch the commands one by one instead.
Finally, there's the issue of the setuid root bit, but screen prints a message about that when an invited user tries to join the screen, so it's clear enough this way (with a bit of doc probably).
Cheers,
Raphaël