OpenStack Compute (nova)

Merge lp://qastaging/~rconradharris/nova/flavor_min_filter into lp://qastaging/~hudson-openstack/nova/trunk

  1. flavor_min_filter
  2. Merge into trunk
Proposed by Rick Harris
Status: Merged
Approved by: Brian Waldon
Approved revision: 1601
Merged at revision: 1616
Proposed branch: lp://qastaging/~rconradharris/nova/flavor_min_filter
Merge into: lp://qastaging/~hudson-openstack/nova/trunk
Diff against target: 720 lines (+364/-90)
10 files modified
nova/api/ec2/admin.py (+3/-2)
nova/api/openstack/flavors.py (+16/-3)
nova/compute/instance_types.py (+6/-2)
nova/db/api.py (+3/-2)
nova/db/sqlalchemy/api.py (+20/-20)
nova/tests/api/openstack/test_flavors.py (+252/-39)
nova/tests/db/fakes.py (+2/-2)
nova/tests/test_instance_types.py (+37/-0)
nova/tests/test_instance_types_extra_specs.py (+23/-18)
nova/tests/vmwareapi/db_fakes.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~rconradharris/nova/flavor_min_filter
Reviewer Review Type Date Requested Status
Brian Waldon (community) Approve
Chris Behrens (community) Approve
Review via email: mp+76455@code.qastaging.launchpad.net

Description of the change

This patch adds flavor filtering, specifically the ability to flavor on minRam, minDisk, or both, per the 1.1 OSAPI spec.

In addition, this patch refactors instance_type_get_all to return a *list* of instance_types instead of a *dict*. This makes it more consistent with the rest of the DB API.

To post a comment you must log in.
Revision history for this message
Naveed Massjouni (ironcamel) wrote :

Hi Rick. Just wanted to let you know about:
https://code.launchpad.net/~rackspace-titan/nova/minram-mindisk
Gonna merge prop it today hopefully. Basically it adds support for minram and mindisk in the api. It displays the minram and mindisk values for GET requests. It also prevents creating instances where the chosen flavor does not meet the minram/mindisk requirements.

Revision history for this message
Gabe Westmaas (westmaas) wrote :

> Hi Rick. Just wanted to let you know about:
> https://code.launchpad.net/~rackspace-titan/nova/minram-mindisk
> Gonna merge prop it today hopefully. Basically it adds support for minram and
> mindisk in the api. It displays the minram and mindisk values for GET
> requests. It also prevents creating instances where the chosen flavor does not
> meet the minram/mindisk requirements.

Just talked to Naveed about this, sorted it out, the code is different, no one is duplicating effort, carry on!

Revision history for this message
Brian Waldon (bcwaldon) wrote :

Looking good, Rick. Can you add some OSAPI tests for the new query parameters? You've also got a little typo on line 130

review: Needs Fixing
Revision history for this message
Rick Harris (rconradharris) wrote :

> Looking good, Rick. Can you add some OSAPI tests for the new query parameters? You've also got a
> little typo on line 130

Fixed typo and added some API level tests.

Revision history for this message
Chris Behrens (cbehrens) wrote :

Great stuff. lgtm.

review: Approve
Revision history for this message
Brian Waldon (bcwaldon) wrote :

Thanks a lot, Rick. This is awesome!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.