Merge lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty into lp://qastaging/address-book-app
Proposed by
Renato Araujo Oliveira Filho
Status: | Approved |
---|---|
Approved by: | Gustavo Pichorim Boiko |
Approved revision: | 514 |
Proposed branch: | lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty |
Merge into: | lp://qastaging/address-book-app |
Diff against target: |
989 lines (+678/-78) 13 files modified
src/imports/ABContactEditorPage.qml (+0/-1) src/imports/ABContactListPage.qml (+20/-1) src/imports/Ubuntu/Contacts/CMakeLists.txt (+2/-0) src/imports/Ubuntu/Contacts/ContactListView.qml (+11/-0) src/imports/Ubuntu/Contacts/MostCalledList.qml (+5/-1) src/imports/Ubuntu/Contacts/contactmap.cpp (+293/-0) src/imports/Ubuntu/Contacts/contactmap.h (+96/-0) src/imports/Ubuntu/Contacts/mostcalledproxymodel.cpp (+8/-69) src/imports/Ubuntu/Contacts/mostcalledproxymodel.h (+0/-4) src/imports/Ubuntu/Contacts/plugin.cpp (+2/-0) tests/qml/CMakeLists.txt (+6/-0) tests/qml/ContactUtil.js (+9/-2) tests/qml/tst_ContactMap.qml (+226/-0) |
To merge this branch: | bzr merge lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gustavo Pichorim Boiko (community) | Approve | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email:
|
Commit message
Only show favorite sections if the list contains favorite contacts.
To post a comment you must log in.
Unmerged revisions
- 519. By Renato Araujo Oliveira Filho
-
Trunk merged.
- 518. By Renato Araujo Oliveira Filho
-
Show all contacts if the header model is reseted.
- 517. By Renato Araujo Oliveira Filho
-
Revert wrong change on last commit.
- 516. By Renato Araujo Oliveira Filho
-
Trunk merged.
- 515. By Renato Araujo Oliveira Filho
-
Trunk merged.
- 514. By Renato Araujo Oliveira Filho
-
Trunk merged.
- 513. By Renato Araujo Oliveira Filho
-
Trunk merged.
- 512. By Renato Araujo Oliveira Filho
-
Show favorite section if the most called model is not empty.
- 511. By Renato Araujo Oliveira Filho
-
Updated mostcalledproxy
model to work with the new history API. - 510. By Renato Araujo Oliveira Filho
-
Async load contacts on ContactMap.
FAILED: Continuous integration, rev:493 jenkins. qa.ubuntu. com/job/ address- book-app- ci/989/ jenkins. qa.ubuntu. com/job/ address- book-app- vivid-i386- ci/292 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 4919/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 4916/console
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/address- book-app- ci/989/ rebuild
http://