Code review comment for lp://qastaging/~renatofilho/qtorganizer5-eds/fix-1616040

Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM, should work fine.

Only minor suggestion is we pull limitDate() 4x in a small paragraph of code.

If QOrganizerRecurrenceRule does something dumb like recalculating it each time limitDate() is called, be better call it just once and cache it in a const temporary.

review: Approve

« Back to merge proposal