Code review comment for lp://qastaging/~renatofilho/sync-monitor/check-network

Revision history for this message
Bill Filler (bfiller) wrote :

Issues:
- if I turn off wifi, the sync still happens
- when wifi is on, as soon as I modify a contact the sync button goes gray but sync monitor delays 60 seconds until it starts the sync. The button shouldn't go gray until an actual sync is in progress. The delay before starting the sync seems much larger now.
- When I turn on flight mode, then sync monitor thinks I'm offline correctly. If I modify a contact during that time the sync button turns gray even though it's not syncing.

review: Needs Fixing

« Back to merge proposal