Code review comment for lp://qastaging/~renatofilho/ubuntu-system-settings-online-accounts/update-account-removal-message

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Online Accounts can't know what an app is doing with a particular account type. It doesn't know, for example, whether my app is using a Google Account for publishing YouTube videos, tracking stocks in Google Finance, or accessing Google Docs for offline reading. And it doesn't know whether, and if so how, my app is caching that data. So it can't possibly delete "all associated data" when I remove the account, and this message would be incorrect.

I understand that you have special-cased syncing of particular data types for particular account types, namely calendars, contacts, and e-mail. You could delete the system-wide copies of *that* data. But you still would not know whether individual apps had cached that data or not, or whether they were using the same account for anything else.

When iOS says that removing a Google account "will remove its calendars, notes and contacts", it can be confident about calendars and contacts because it provides apps with access to those particular things -- via EventKit and ABAddressBook* respectively -- and not to the Google account itself. (I don't know understand what "notes" refers to in the message, though.)

review: Disapprove (design)

« Back to merge proposal