Code review comment for lp://qastaging/~rick-rickspencer3/desktopcouch/notempviewsmods

Revision history for this message
Chad Miller (cmiller) wrote :

I don't think we want to push a specific record type in a general function that we store. Consider:

rows = get_records(self, record_type="foo", create_view=True)
rows = get_records(self, record_type=" BAR", create_view=True)

The second call is going to give values of "foo", because it's stored in the design document from the first time.

You have to either remove storing the record type or name the view with the record_type.

review: Needs Fixing

« Back to merge proposal