OpenStack Compute (nova)

Merge lp://qastaging/~rlane/nova/lp773690 into lp://qastaging/~hudson-openstack/nova/trunk

  1. lp773690
  2. Merge into trunk
Proposed by Ryan Lane
Status: Work in progress
Proposed branch: lp://qastaging/~rlane/nova/lp773690
Merge into: lp://qastaging/~hudson-openstack/nova/trunk
Diff against target: 29 lines (+12/-5)
1 file modified
bin/nova-ajax-console-proxy (+12/-5)
To merge this branch: bzr merge lp://qastaging/~rlane/nova/lp773690
Reviewer Review Type Date Requested Status
Vish Ishaya (community) Approve
Cory Wright (community) Approve
Review via email: mp+59565@code.qastaging.launchpad.net

Description of the change

Only uses HTTP_REFERER if HTTP_REFERER has token set. Fix for using ajax console urls in iframes.

To post a comment you must log in.
lp://qastaging/~rlane/nova/lp773690 updated
406. By Ryan Lane

Only parse url if needed.

407. By Ryan Lane

Ensure the auth_params are set, even if HTTP_REFERER does not contain a token. Also, document why we must do this check.

Revision history for this message
Cory Wright (corywright) wrote :

Straightforward enough. lgtm.

review: Approve
Reply
Revision history for this message
Vish Ishaya (vishvananda) wrote :

lgtm as well

review: Approve
Reply
Revision history for this message
Vish Ishaya (vishvananda) wrote :

I suppose we should actually require a test for this, although I'm not totally sure there is one that would make sense here. Ryan, do you see a way to write a simple test here?

Reply
Revision history for this message
Devin Carlen (devcamcar) wrote :

Setting to work in progress while the testing strategy for this is determined.

Reply
Revision history for this message
Ryan Lane (rlane) wrote :

Yes. I can write a test for this.

Reply

Unmerged revisions

407. By Ryan Lane

Ensure the auth_params are set, even if HTTP_REFERER does not contain a token. Also, document why we must do this check.

406. By Ryan Lane

Only parse url if needed.

405. By Ryan Lane

Only uses HTTP_REFERER if HTTP_REFERER has token set

404. By Ryan Lane

Merge from trunk

403. By Ryan Lane

Merge from trunk

402. By Ryan Lane

Merge from trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.