Code review comment for lp://qastaging/~roadmr/ubuntu/precise/checkbox/0.13.1-retry

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Not blockers (I'll fix those myself for this upload):
 - (in debian/control) Uploaders vs. XSBC-Original-Maintainer : these changes are unnecessary. The package is not in Debian, so both fields were actually superfluous. Uploaders is specifically for Debian to say someone is allowed to upload a particular package without going through the NMU process; XSBC-Original-Maintainer is a field for Ubuntu to keep track of the original maintainer for the Debian package when the maintainer was changed due to Ubuntu deltas.
 - (in debian/changelog) "Nixed graphics...." change was misplaced in the previous 0.13 version. This is incorrect; probably just a small mistake in using "dch -a" instead of "dch -i" on a released version of checkbox; since it belongs to 0.13.1.

« Back to merge proposal