Merge lp://qastaging/~robru/notify-osd/inline-packaging into lp://qastaging/~canonical-dx-team/notify-osd/precise

Proposed by Robert Bruce Park
Status: Rejected
Rejected by: Didier Roche-Tolomelli
Proposed branch: lp://qastaging/~robru/notify-osd/inline-packaging
Merge into: lp://qastaging/~canonical-dx-team/notify-osd/precise
Diff against target: 969 lines (+913/-0)
11 files modified
.bzr-builddeb/default.conf (+2/-0)
debian/changelog (+683/-0)
debian/compat (+1/-0)
debian/control (+33/-0)
debian/copyright (+49/-0)
debian/notify-osd.install (+1/-0)
debian/notify-osd.postinst (+10/-0)
debian/notify-osd.postrm (+20/-0)
debian/notify-osd.preinst (+23/-0)
debian/rules (+8/-0)
debian/source_notify-osd.py (+83/-0)
To merge this branch: bzr merge lp://qastaging/~robru/notify-osd/inline-packaging
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Didier Roche-Tolomelli Needs Fixing
Review via email: mp+135778@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote :

Didier: lp:notify-osd trunk seems to point at precise? Not sure what should be done about that (if anything).

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Asking Macslow about the status…

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

oh, and meanwhile, about the packaging:

878 +include /usr/share/cdbs/1/rules/autoreconf.mk
879 +include /usr/share/cdbs/1/class/gnome.mk
880 +include /usr/share/cdbs/1/rules/debhelper.mk
881 +

-> this is using cdbs (see the cdbs depends in debian/control), would be cool to use the full debhelper 9 capabilities, meaning removing the cdbs build-dep and changing debian/rules to have the traditional dh calls and overrides :)

review: Needs Fixing
Revision history for this message
Mirco Müller (macslow) wrote :

There has not been any work happening since 0.9.34 (for 12.04), that's why it didn't change.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote :

Updated Jenkins jobs, should autoland naturally upon approval (pending didrocks' suggestions of course).

458. By Robert Bruce Park

Convert from cdbs to dh9.

Revision history for this message
Robert Bruce Park (robru) wrote :

Didier: so I took a stab at converting this cdbs stuff into 'regular' dh9 and it seems to be building normally, however the testsuite is failing. It looks like the tests are trying (and failing) to open the display, so I guess the testsuite is just not mocked properly in order to pass. Somebody who knows more about this project should probably have a look at this. ;-)

Here is the relevant snippet from the build log:

make[3]: Entering directory `/home/robru/Packages/notify-osd/build-area/notify-osd-0.9.35/tests'

(./test-modules:8986): Gtk-WARNING **: cannot open display:
/bin/bash: line 5: 8986 Trace/breakpoint trap (core dumped) ${dir}$tst
FAIL: test-modules
======================================
1 of 1 test failed
Please report to <email address hidden>
======================================
make[3]: *** [check-TESTS] Error 1
make[3]: Leaving directory `/home/robru/Packages/notify-osd/build-area/notify-osd-0.9.35/tests'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/home/robru/Packages/notify-osd/build-area/notify-osd-0.9.35/tests'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/home/robru/Packages/notify-osd/build-area/notify-osd-0.9.35'
dh_auto_test: make -j1 test returned exit code 2
make: *** [build] Error 29
dpkg-buildpackage: error: debian/rules build gave error exit status 2
debuild: fatal error at line 1357:
dpkg-buildpackage -rfakeroot -D -us -uc failed
bzr: ERROR: The build failed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

The debhelper 9 stenza looks good!

I think the testsuite needs to use xfvb for running, I'll ask Michael when he's around to have a look :)

Thanks for this work!

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

(ah, also, just a side-note raring -> UNRELEASED)

Revision history for this message
Allan LeSage (allanlesage) wrote :

You might have a look at indicator-application, it's doing some xvfb dark magic to run its tests in a chroot.

Revision history for this message
Michael Terry (mterry) wrote :

I filed https://code.launchpad.net/~mterry/notify-osd/inline2/+merge/136258 which adds a dep8 test for running the test suite.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

mterry's branch superseed this one.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches